[clang] [clang] Add CodeGen tests for CWG 5xx issues (PR #84303)
Vlad Serebrennikov via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 7 02:55:26 PST 2024
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/84303
This patch covers
[CWG519](https://cplusplus.github.io/CWG/issues/519.html) "Null pointer preservation in `void*` conversions",
[CWG571](https://cplusplus.github.io/CWG/issues/571.html) "References declared const".
>From c9f7b8daadae24ff9673e58ab6d28c40440d6275 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov <serebrennikov.vladislav at gmail.com>
Date: Thu, 7 Mar 2024 13:32:35 +0300
Subject: [PATCH 1/3] [clang] Add CodeGen tests for CWG 5xx issues
This patch covers
[CWG519](https://cplusplus.github.io/CWG/issues/519.html) "Null pointer preservation in `void*` conversions ",
[CWG571](https://cplusplus.github.io/CWG/issues/571.html) "References declared const".
---
clang/test/CXX/drs/dr519.cpp | 36 ++++++++++++++++++++++++++++++++++++
clang/test/CXX/drs/dr571.cpp | 21 +++++++++++++++++++++
clang/test/CXX/drs/dr5xx.cpp | 19 ++-----------------
clang/www/cxx_dr_status.html | 4 ++--
4 files changed, 61 insertions(+), 19 deletions(-)
create mode 100644 clang/test/CXX/drs/dr519.cpp
create mode 100644 clang/test/CXX/drs/dr571.cpp
diff --git a/clang/test/CXX/drs/dr519.cpp b/clang/test/CXX/drs/dr519.cpp
new file mode 100644
index 00000000000000..42328f89ba7cdf
--- /dev/null
+++ b/clang/test/CXX/drs/dr519.cpp
@@ -0,0 +1,36 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++14 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++17 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++20 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++23 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++2c %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+
+namespace dr519 { // dr519: 2.7
+void f() {
+ int *a = 0;
+ void *v = a;
+ bool c1 = v == static_cast<void *>(0);
+
+ void *w = 0;
+ int *b = static_cast<int*>(w);
+ bool c2 = b == static_cast<int *>(0);
+}
+} // namespace dr519
+
+// We're checking that `null`s that were initially stored in `a` and `w`
+// are simply copied over all the way to respective comparisons with `null`.
+
+// CHECK-LABEL: define {{.*}} void dr519::f()()
+// CHECK: store ptr null, ptr [[A:%.+]],
+// CHECK-NEXT: [[TEMP_A:%.+]] = load ptr, ptr [[A]]
+// CHECK-NEXT: store ptr [[TEMP_A]], ptr [[V:%.+]],
+// CHECK-NEXT: [[TEMP_V:%.+]] = load ptr, ptr [[V]]
+// CHECK-NEXT: {{.+}} = icmp eq ptr [[TEMP_V]], null
+
+// CHECK: store ptr null, ptr [[W:%.+]],
+// CHECK-NEXT: [[TEMP_W:%.+]] = load ptr, ptr [[W]]
+// CHECK-NEXT: store ptr [[TEMP_W]], ptr [[B:%.+]],
+// CHECK-NEXT: [[TEMP_B:%.+]] = load ptr, ptr [[B]]
+// CHECK-NEXT: {{.+}} = icmp eq ptr [[TEMP_B]], null
+// CHECK-LABEL: }
diff --git a/clang/test/CXX/drs/dr571.cpp b/clang/test/CXX/drs/dr571.cpp
new file mode 100644
index 00000000000000..64f143443cddc3
--- /dev/null
+++ b/clang/test/CXX/drs/dr571.cpp
@@ -0,0 +1,21 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++14 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++17 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++20 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++23 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++2c %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK
+
+namespace dr571 { // dr571: 2.7
+ typedef int &ir;
+ int n;
+ const ir r = n;
+ // expected-warning at -1 {{'const' qualifier on reference type 'ir' (aka 'int &') has no effect}}
+ ir r2 = n;
+}
+
+// Entities have external linkage by default.
+// `dso_local` is not a linkage specification.
+
+// CHECK: @dr571::r = dso_local constant ptr @dr571::n
+// CHECK: @dr571::r2 = dso_local constant ptr @dr571::n
\ No newline at end of file
diff --git a/clang/test/CXX/drs/dr5xx.cpp b/clang/test/CXX/drs/dr5xx.cpp
index 0e1de342f6706f..426b368b390ae6 100644
--- a/clang/test/CXX/drs/dr5xx.cpp
+++ b/clang/test/CXX/drs/dr5xx.cpp
@@ -141,15 +141,7 @@ namespace dr518 { // dr518: yes c++11
// cxx98-error at -1 {{commas at the end of enumerator lists are a C++11 extension}}
}
-namespace dr519 { // dr519: yes
-// FIXME: Add a codegen test.
-#if __cplusplus >= 201103L
-#define fold(x) (__builtin_constant_p(x) ? (x) : (x))
- int test[fold((int*)(void*)0) ? -1 : 1];
-#undef fold
-#endif
-}
-
+// dr519 is in dr519.cpp
// dr520: na
// dr521: no
@@ -800,14 +792,7 @@ namespace dr570 { // dr570: dup 633
// expected-note@#dr570-r {{previous definition is here}}
}
-namespace dr571 { // dr571 unknown
- // FIXME: Add a codegen test.
- typedef int &ir;
- int n;
- // FIXME: Test if this has internal linkage.
- const ir r = n;
- // expected-warning at -1 {{'const' qualifier on reference type 'ir' (aka 'int &') has no effect}}
-}
+// dr571 is in dr571.cpp
namespace dr572 { // dr572: yes
enum E { a = 1, b = 2 };
diff --git a/clang/www/cxx_dr_status.html b/clang/www/cxx_dr_status.html
index 774c71bc1cb6b7..503472a2cae4eb 100755
--- a/clang/www/cxx_dr_status.html
+++ b/clang/www/cxx_dr_status.html
@@ -3154,7 +3154,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2>
<td><a href="https://cplusplus.github.io/CWG/issues/519.html">519</a></td>
<td>CD1</td>
<td>Null pointer preservation in <TT>void*</TT> conversions</td>
- <td class="full" align="center">Yes</td>
+ <td class="full" align="center">Clang 2.7</td>
</tr>
<tr id="520">
<td><a href="https://cplusplus.github.io/CWG/issues/520.html">520</a></td>
@@ -3468,7 +3468,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2>
<td><a href="https://cplusplus.github.io/CWG/issues/571.html">571</a></td>
<td>CD2</td>
<td>References declared <TT>const</TT></td>
- <td class="unknown" align="center">Unknown</td>
+ <td class="full" align="center">Clang 2.7</td>
</tr>
<tr id="572">
<td><a href="https://cplusplus.github.io/CWG/issues/572.html">572</a></td>
>From 123a79e97b0aedfcbadbb8a3500d240d0f9cfaf7 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov <serebrennikov.vladislav at gmail.com>
Date: Thu, 7 Mar 2024 13:34:05 +0300
Subject: [PATCH 2/3] Add missing newline at the end of file
---
clang/test/CXX/drs/dr571.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/test/CXX/drs/dr571.cpp b/clang/test/CXX/drs/dr571.cpp
index 64f143443cddc3..a1b83c073a085b 100644
--- a/clang/test/CXX/drs/dr571.cpp
+++ b/clang/test/CXX/drs/dr571.cpp
@@ -18,4 +18,4 @@ namespace dr571 { // dr571: 2.7
// `dso_local` is not a linkage specification.
// CHECK: @dr571::r = dso_local constant ptr @dr571::n
-// CHECK: @dr571::r2 = dso_local constant ptr @dr571::n
\ No newline at end of file
+// CHECK: @dr571::r2 = dso_local constant ptr @dr571::n
>From 3ad09b07b8b93c36ec2e3ab792bbf366caa4d4e1 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov <serebrennikov.vladislav at gmail.com>
Date: Thu, 7 Mar 2024 13:54:19 +0300
Subject: [PATCH 3/3] Fix test patterns
---
clang/test/CXX/drs/dr519.cpp | 2 +-
clang/test/CXX/drs/dr571.cpp | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/clang/test/CXX/drs/dr519.cpp b/clang/test/CXX/drs/dr519.cpp
index 42328f89ba7cdf..67c01d95ef7c6f 100644
--- a/clang/test/CXX/drs/dr519.cpp
+++ b/clang/test/CXX/drs/dr519.cpp
@@ -21,7 +21,7 @@ void f() {
// We're checking that `null`s that were initially stored in `a` and `w`
// are simply copied over all the way to respective comparisons with `null`.
-// CHECK-LABEL: define {{.*}} void dr519::f()()
+// CHECK-LABEL: define {{.*}} void @dr519::f()()
// CHECK: store ptr null, ptr [[A:%.+]],
// CHECK-NEXT: [[TEMP_A:%.+]] = load ptr, ptr [[A]]
// CHECK-NEXT: store ptr [[TEMP_A]], ptr [[V:%.+]],
diff --git a/clang/test/CXX/drs/dr571.cpp b/clang/test/CXX/drs/dr571.cpp
index a1b83c073a085b..19a85b7ddc3508 100644
--- a/clang/test/CXX/drs/dr571.cpp
+++ b/clang/test/CXX/drs/dr571.cpp
@@ -15,7 +15,6 @@ namespace dr571 { // dr571: 2.7
}
// Entities have external linkage by default.
-// `dso_local` is not a linkage specification.
-// CHECK: @dr571::r = dso_local constant ptr @dr571::n
-// CHECK: @dr571::r2 = dso_local constant ptr @dr571::n
+// CHECK: @dr571::r = constant ptr @dr571::n
+// CHECK: @dr571::r2 = constant ptr @dr571::n
More information about the cfe-commits
mailing list