Sirraide wrote: Alright, the changes look sensible to me, but I’d like for someone who’s more familiar with this part of Clang or with the original pr to comment on them too before we merge it. https://github.com/llvm/llvm-project/pull/84014