[clang] [clang] Implement CTAD for type alias template. (PR #77890)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 5 06:35:53 PST 2024


================
@@ -2612,44 +2671,309 @@ struct ConvertConstructorToDeductionGuideTransform {
     SemaRef.CurrentInstantiationScope->InstantiatedLocal(OldParam, NewParam);
     return NewParam;
   }
+};
 
-  FunctionTemplateDecl *buildDeductionGuide(
-      TemplateParameterList *TemplateParams, CXXConstructorDecl *Ctor,
-      ExplicitSpecifier ES, TypeSourceInfo *TInfo, SourceLocation LocStart,
-      SourceLocation Loc, SourceLocation LocEnd,
-      llvm::ArrayRef<TypedefNameDecl *> MaterializedTypedefs = {}) {
-    DeclarationNameInfo Name(DeductionGuideName, Loc);
-    ArrayRef<ParmVarDecl *> Params =
-        TInfo->getTypeLoc().castAs<FunctionProtoTypeLoc>().getParams();
+// Find all template parameters of the AliasTemplate that appear in the
+// given DeducedArgs.
+SmallVector<unsigned>
+FindAppearedTemplateParamsInAlias(ArrayRef<TemplateArgument> DeducedArgs,
----------------
erichkeane wrote:

The generic suggestion is because it would, I believe, make this a much more readable function with very minor changes in the 'use'.  So I think there is value there.

I see what you mean about the index, I think it is alright to leave the index part.

https://github.com/llvm/llvm-project/pull/77890


More information about the cfe-commits mailing list