[clang] [llvm] [HLSL] implement `mad` intrinsic (PR #83826)
Justin Bogner via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 4 10:14:56 PST 2024
================
@@ -19812,11 +19821,13 @@ bool Sema::SemaBuiltinElementwiseTernaryMath(CallExpr *TheCall) {
Args[I] = Converted.get();
}
- int ArgOrdinal = 1;
- for (Expr *Arg : Args) {
- if (checkFPMathBuiltinElementType(*this, Arg->getBeginLoc(), Arg->getType(),
- ArgOrdinal++))
- return true;
+ if (enforceFloatingPointCheck) {
+ int ArgOrdinal = 1;
+ for (Expr *Arg : Args) {
+ if (checkFPMathBuiltinElementType(*this, Arg->getBeginLoc(),
+ Arg->getType(), ArgOrdinal++))
----------------
bogner wrote:
I was mostly commenting on the jump from "math builtin" to "matrix type" as far as naming goes, but I don't spend a lot of time in Sema. My point is that I think we may still want some check here, I'm just not sure what without looking at it in more detail.
https://github.com/llvm/llvm-project/pull/83826
More information about the cfe-commits
mailing list