[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 4 07:02:34 PST 2024


================
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) {
 }
 
 bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) {
-  return DKind == OMPD_teams || DKind == OMPD_teams_distribute ||
-         DKind == OMPD_teams_distribute_simd ||
-         DKind == OMPD_teams_distribute_parallel_for_simd ||
-         DKind == OMPD_teams_distribute_parallel_for ||
-         DKind == OMPD_teams_loop;
+  if (DKind == OMPD_teams)
+    return true;
+  auto leafs = getLeafConstructs(DKind);
----------------
erichkeane wrote:

Huh, interestingly, that Merriam Webster link is the only one I can find that acknowledges `leafs` as a plural for the general case.  The only other case I could find was wiktionary: https://en.wiktionary.org/wiki/leaf

Which shows that `leafs` is valid in 2 cases: when talking about multi-section doors, or when used as a pejorative for a Canadian.  So I don't really know anything anymore.

That said, while LLVM's policy is only 'english' and doesn't specify American, Canadian, or British English, by practice we use American English spellings for things.

https://github.com/llvm/llvm-project/pull/83625


More information about the cfe-commits mailing list