[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

Krzysztof Parzyszek via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 3 15:59:38 PST 2024


================
@@ -231,6 +244,8 @@ static void EmitDirectivesDecl(RecordKeeper &Records, raw_ostream &OS) {
   OS << "bool isAllowedClauseForDirective(Directive D, "
      << "Clause C, unsigned Version);\n";
   OS << "\n";
+  OS << "const llvm::SmallVector<Directive> &getLeafConstructs(Directive D);\n";
----------------
kparzysz wrote:

I don't think this is a good idea.  Returning a reference is pretty much free, Returning an ArrayRef will always create a temporary object.  You can always use ArrayRef in the caller, if that's what's desired there.

https://github.com/llvm/llvm-project/pull/83625


More information about the cfe-commits mailing list