[clang] [clang][modules] Headers meant to be included multiple times can be completely invisible in clang module builds (PR #83660)

via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 1 22:31:30 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 07317bbc66d1f2d7663af3c9f04d0f6c0487ac03 171d0e299dd676ce29583e16fdf8c3e6f3dd7925 -- clang/include/clang/Lex/HeaderSearch.h clang/lib/Lex/HeaderSearch.cpp clang/lib/Serialization/ASTReader.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Lex/HeaderSearch.cpp b/clang/lib/Lex/HeaderSearch.cpp
index fb6ec456dd..f56781e785 100644
--- a/clang/lib/Lex/HeaderSearch.cpp
+++ b/clang/lib/Lex/HeaderSearch.cpp
@@ -1432,7 +1432,8 @@ void HeaderSearch::MarkFileModuleHeader(FileEntryRef FE,
 
   auto &HFI = getFileInfo(FE);
   HFI.mergeModuleMembership(Role);
-  HFI.isCompilingModuleHeader |= (HFI.isModuleHeader && isCompilingModuleHeader);
+  HFI.isCompilingModuleHeader |=
+      (HFI.isModuleHeader && isCompilingModuleHeader);
 }
 
 bool HeaderSearch::ShouldEnterIncludeFile(Preprocessor &PP,

``````````

</details>


https://github.com/llvm/llvm-project/pull/83660


More information about the cfe-commits mailing list