[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (PR #83331)

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 1 12:36:21 PST 2024


================
@@ -11,7 +11,6 @@
 // NOINLINE-NOT: "-fsplit-dwarf-inlining"
 // SPLIT-NOT:  "-dumpdir"
 // SPLIT:      "-debug-info-kind=constructor"
-// SPLIT-SAME: "-ggnu-pubnames"
----------------
dwblaikie wrote:

Nah, I think that's probably fine without an explicit `-ggdb` test - though with the test as-is, wouldn't it fail on macos machines, where they'll implicitly default to `-glldb` and so `-ggnu-pubnames` won't get passed, so the check on line 14 of split-debug.c will fail? So maybe that has to be removed from there and only checked via explicit tuning flags, in which case adding a `-ggdb` test would be necessary (though it could share the CHECK lines from the `-glldb -ggnu-pubnames` test)

https://github.com/llvm/llvm-project/pull/83331


More information about the cfe-commits mailing list