[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

Fangrui Song via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 1 11:51:06 PST 2024


================
@@ -4478,14 +4478,20 @@ renderDebugOptions(const ToolChain &TC, const Driver &D, const llvm::Triple &T,
       Args.getLastArg(options::OPT_ggnu_pubnames, options::OPT_gno_gnu_pubnames,
                       options::OPT_gpubnames, options::OPT_gno_pubnames);
   if (DwarfFission != DwarfFissionKind::None ||
-      (PubnamesArg && checkDebugInfoOption(PubnamesArg, Args, D, TC)))
-    if (!PubnamesArg ||
-        (!PubnamesArg->getOption().matches(options::OPT_gno_gnu_pubnames) &&
-         !PubnamesArg->getOption().matches(options::OPT_gno_pubnames)))
+      (PubnamesArg && checkDebugInfoOption(PubnamesArg, Args, D, TC))) {
+    const bool OptionSet =
----------------
MaskRay wrote:

The title reads as `-ggnu-pubnames` is removed for all DWARF v5 split-dwarf configurations, but the code seems to say lldb tuning. The title is worth clarification.

https://github.com/llvm/llvm-project/pull/83331


More information about the cfe-commits mailing list