[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

Chris B via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 29 10:03:21 PST 2024


================
@@ -10266,6 +10266,11 @@ def err_block_on_vm : Error<
 def err_sizeless_nonlocal : Error<
   "non-local variable with sizeless type %0">;
 
+def err_vec_builtin_non_vector_all : Error<
+ "all arguments to %0 must be vectors">;
+def err_vec_builtin_incompatible_vector_all : Error<
+  "all arguments to %0 must have vectors of the same type">;
----------------
llvm-beanz wrote:

I disagree here. I think we should collapse these down. You can use a `%select{...}` block in the error format string to support the old message and the new message from the same diagnostic entry.

These diagnostic strings end up becoming some pretty large constant data tables in the final clang executable so we've generally tried to reuse errors where it makes sense.

https://github.com/llvm/llvm-project/pull/83077


More information about the cfe-commits mailing list