[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 29 04:46:10 PST 2024


================
@@ -1626,7 +1626,8 @@ class [[nodiscard]] APInt {
   /// SmallString. If Radix > 10, UpperCase determine the case of letter
   /// digits.
   void toString(SmallVectorImpl<char> &Str, unsigned Radix, bool Signed,
-                bool formatAsCLiteral = false, bool UpperCase = true) const;
+                bool formatAsCLiteral = false, bool UpperCase = true,
+                bool insertSeparators = false) const;
----------------
AaronBallman wrote:

```suggestion
                bool InsertSeparators = false) const;
```
This matches our usual coding style and is the prevailing style in the function signature (a follow-up NFC change could rename `formatAsCLiteral`).

https://github.com/llvm/llvm-project/pull/80939


More information about the cfe-commits mailing list