[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

zhijian lin via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 28 13:57:54 PST 2024


================
@@ -364,7 +364,14 @@ class LLVM_LIBRARY_VISIBILITY PPCTargetInfo : public TargetInfo {
   // have Glibc since it is Glibc that provides the HWCAP[2] in the auxv.
   static constexpr int MINIMUM_AIX_OS_MAJOR = 7;
   static constexpr int MINIMUM_AIX_OS_MINOR = 2;
-  bool supportsCpuSupports() const override { return getTriple().isOSGlibc(); }
+  bool supportsCpuSupports() const override {
----------------
diggerlin wrote:

> Does this need to be a separate function if it is the same as `supportsCpuIs()`? Can they be combined?

yes, we can combined them , but it need another NFC to do it. since not only PPC.h has the two function but also X86.h 
  

https://github.com/llvm/llvm-project/pull/82809


More information about the cfe-commits mailing list