[clang] [clang] Refactor target attribute mangling. (PR #81893)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 27 07:38:38 PST 2024


https://github.com/erichkeane commented:

Hi-
Sorry for the delay, I didn't see the updated commit, so thanks for the ping.

In general this is 'about right', but I don't like the 'getManglingSuffix' type of thing.  I believe we should have these functions take an ostream and append to it, that way we save the copies that end up coming from trucking std::strings all around.


https://github.com/llvm/llvm-project/pull/81893


More information about the cfe-commits mailing list