[clang] [llvm] [llvm-ar][Archive] Use getDefaultTargetTriple instead of host triple for the fallback archive format. (PR #82888)

James Henderson via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 27 00:06:21 PST 2024


https://github.com/jh7370 approved this pull request.

LGTM. I considered if there was any way of testing this, but the only way I ould think of was to have lit know the default target triple (it might well do that) and then somehow leverage that to convert to a check for the "expected" format for an empty archive. I guess a python script that takes the default triple and inspects the output archive might be possible, but it's may not be worth it. If you want to go down that route, feel free (and I'd be happy to review), but I'm not going to require it.

https://github.com/llvm/llvm-project/pull/82888


More information about the cfe-commits mailing list