[clang] [clang][Diagnostic] Don't warn about binary literals when using C23. (PR #80244)

Collin Funk via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 24 14:02:36 PST 2024


collinfunk wrote:

> Thank you for this PR. This change should have some tests to verify the behavior is correct. I am a little surprised that this does not change any existing tests but maybe we don't have good test coverage.

Hi, thanks for the review. Sorry for the lack of tests. I'm not super familiar with LLVM's code and didn't know how to add them. In any case, I believe that this issue was fixed in the following pull requests along with better Diagnostic groups:

https://github.com/llvm/llvm-project/pull/81658

Can you double check and make sure I am not mistaken? Thanks.


https://github.com/llvm/llvm-project/pull/80244


More information about the cfe-commits mailing list