[clang] [clang][CodeGen] Keep processing the rest of AST after encountering unsupported MC/DC expressions (PR #82464)

Alan Phipps via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 22 10:54:47 PST 2024


================
@@ -292,7 +295,7 @@ struct MapRegionCounters : public RecursiveASTVisitor<MapRegionCounters> {
                 "contains an operation with a nested boolean expression. "
                 "Expression will not be covered");
             Diag.Report(S->getBeginLoc(), DiagID);
-            return false;
+            return true;
----------------
evodius96 wrote:

Yes, that's what I mean.  There was no benefit in returning false to begin with; you have to return true.  The checking that the pass does to catch the case, issue the diagnostic, and avoid processing of the data for the expression is sufficient to handle the case.

https://github.com/llvm/llvm-project/pull/82464


More information about the cfe-commits mailing list