[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

Artem Dergachev via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 21 13:56:06 PST 2024


haoNoQ wrote:

> > I want to spend a bit more time thinking whether this has to go into every callback, maybe it can be a set-and-forget thing? (Probably not.)
> 
> What do you mean by set-and-forget?

I mean like, so that you didn't have to remember to edit every callback in a specific way in order to have caching for every callback. But it might also be a bad idea given that we probably don't actually want every callback to be cached. But maybe there's a way to also make it flexible, dunno.

Yeah I don't immediately see how to do that, your solution is probably perfect. Can you confirm that only 5 callbacks currently need to be cached? If yes, it's probably be great to just edit them manually to add caching when necessary, because now it's a conscious decision.

https://github.com/llvm/llvm-project/pull/82229


More information about the cfe-commits mailing list