[clang] [Clang][Sema] Remove invalid ctor (NFC) (PR #82161)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 18 04:10:33 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Alexander (Smertig)
<details>
<summary>Changes</summary>
`TemplateArgumentLocInventIterator` default constructor should not exists
https://github.com/llvm/llvm-project/blob/3496927edcd0685807351ba88a7e2cfb006e1c0d/clang/lib/Sema/TreeTransform.h#L4742
because it doesn't and couldn't initialize `Self` member that is reference:
https://github.com/llvm/llvm-project/blob/3496927edcd0685807351ba88a7e2cfb006e1c0d/clang/lib/Sema/TreeTransform.h#L4721-L4723
Instantiation of this constructor is always a compile-time error.
Please note, that I didn't run any tests, because cannot imagine situation where this constructor can be properly used. There's no new tests for this fix for the same reason.
---
Full diff: https://github.com/llvm/llvm-project/pull/82161.diff
1 Files Affected:
- (modified) clang/lib/Sema/TreeTransform.h (-2)
``````````diff
diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h
index a32a585531873a..07f11c965cde62 100644
--- a/clang/lib/Sema/TreeTransform.h
+++ b/clang/lib/Sema/TreeTransform.h
@@ -4739,8 +4739,6 @@ class TemplateArgumentLocInventIterator {
const TemplateArgumentLoc *operator->() const { return &Arg; }
};
- TemplateArgumentLocInventIterator() { }
-
explicit TemplateArgumentLocInventIterator(TreeTransform<Derived> &Self,
InputIterator Iter)
: Self(Self), Iter(Iter) { }
``````````
</details>
https://github.com/llvm/llvm-project/pull/82161
More information about the cfe-commits
mailing list