[clang] 4a32a41 - [clang] Fix two gcc warnings about unused variables [NFC]

[Mikael Holmen via cfe-commits]

Author: Mikael Holmen
Date: 2024-02-15T10:31:59+01:00
New Revision: 4a32a414ee07bf15c47ba7fb7286d968e73a04fe

URL: https://github.com/llvm/llvm-project/commit/4a32a414ee07bf15c47ba7fb7286d968e73a04fe
DIFF: https://github.com/llvm/llvm-project/commit/4a32a414ee07bf15c47ba7fb7286d968e73a04fe.diff

LOG: [clang] Fix two gcc warnings about unused variables [NFC]

Without the fix gcc warns like
 ../../clang/lib/Sema/SemaDecl.cpp:2963:24: warning: unused variable 'SupA' [-Wunused-variable]
  2963 |   else if (const auto *SupA = dyn_cast<SuppressAttr>(Attr))
       |                        ^~~~
and
 ../../clang/lib/Driver/Driver.cpp:4192:17: warning: unused variable 'IAA' [-Wunused-variable]
  4192 |       if (auto *IAA = dyn_cast<InstallAPIJobAction>(Current)) {
       |                 ^~~

Remove the unused variables and change the "dyn_cast"s into "isa"s.

Added: 
    

Modified: 
    clang/lib/Driver/Driver.cpp
    clang/lib/Sema/SemaDecl.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp
index cf84ef21dfa8ce..5a323bf4c0c5f4 100644
--- a/clang/lib/Driver/Driver.cpp
+++ b/clang/lib/Driver/Driver.cpp
@@ -4189,7 +4189,7 @@ void Driver::BuildActions(Compilation &C, DerivedArgList &Args,
         break;
       }
 
-      if (auto *IAA = dyn_cast<InstallAPIJobAction>(Current)) {
+      if (isa<InstallAPIJobAction>(Current)) {
         Current = nullptr;
         break;
       }

diff  --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp
index 09a35fddba1954..0aaaba0e5d15f9 100644
--- a/clang/lib/Sema/SemaDecl.cpp
+++ b/clang/lib/Sema/SemaDecl.cpp
@@ -2960,7 +2960,7 @@ static bool mergeDeclAttribute(Sema &S, NamedDecl *D,
         S.mergeHLSLNumThreadsAttr(D, *NT, NT->getX(), NT->getY(), NT->getZ());
   else if (const auto *SA = dyn_cast<HLSLShaderAttr>(Attr))
     NewAttr = S.mergeHLSLShaderAttr(D, *SA, SA->getType());
-  else if (const auto *SupA = dyn_cast<SuppressAttr>(Attr))
+  else if (isa<SuppressAttr>(Attr))
     // Do nothing. Each redeclaration should be suppressed separately.
     NewAttr = nullptr;
   else if (Attr->shouldInheritEvenIfAlreadyPresent() || !DeclHasAttr(D, Attr))