[clang] [-Wunsafe-buffer-usage] Fixits for unsafe arguments of function pointer calls (PR #80358)

Artem Dergachev via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 13 15:29:48 PST 2024


================
@@ -282,8 +282,8 @@ isInUnspecifiedPointerContext(internal::Matcher<Stmt> InnerMatcher) {
   //    (i.e., computing the distance between two pointers); or ...
 
   auto CallArgMatcher =
-      callExpr(forEachArgumentWithParam(InnerMatcher,
-                  hasPointerType() /* array also decays to pointer type*/),
+      callExpr(forEachArgumentWithParamType(InnerMatcher,
+                  isAnyPointer() /* array also decays to pointer type*/),
----------------
haoNoQ wrote:

Original code uses `hasPointerType()` which is inconvenient here because it includes the `hasType()` part, but another thing it was doing was `hasCanonicalType()` which is now missing. Are you sure it's not necessary in this case?

https://github.com/llvm/llvm-project/pull/80358


More information about the cfe-commits mailing list