[clang] [llvm] [llvm][AArch64] Do not inline a function with different signing scheme. (PR #80642)

Nick Desaulniers via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 13 09:48:22 PST 2024


================
@@ -5155,7 +5155,39 @@ struct StrictFPUpgradeVisitor : public InstVisitor<StrictFPUpgradeVisitor> {
 };
 } // namespace
 
-void llvm::UpgradeFunctionAttributes(Function &F) {
+static void
+CopyModuleAttributeToFunction(Function &F, StringRef FnAttrName,
+                              StringRef ModAttrName,
+                              std::pair<StringRef, StringRef> Values) {
----------------
nickdesaulniers wrote:

Can you add a comment about what the pair of StringRef are supposed to refer to? The parameter identifier of Values doesn't betray what the caller should be passing here.

https://github.com/llvm/llvm-project/pull/80642


More information about the cfe-commits mailing list