[clang] [clang][ASTImporter] fix assert fail due to offset overflow (PR #79084)

Michael Buch via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 12 07:09:33 PST 2024


================
@@ -9896,9 +9903,13 @@ Expected<FileID> ASTImporter::Import(FileID FromID, bool IsBuiltin) {
         // FIXME: The filename may be a virtual name that does probably not
         // point to a valid file and we get no Entry here. In this case try with
         // the memory buffer below.
-        if (Entry)
+        if (Entry) {
+          if (isBufferSizeOverflow(ToSM, Entry->getSize()))
+            return llvm::make_error<ASTImportError>(
+                ASTImportError::UnsupportedConstruct);
----------------
Michael137 wrote:

> This error is clearly not an unsupported AST construct. For this case a new error type should be added like ASTImportError::SourceLocationOverflow or ResourceOverflow

Agreed

https://github.com/llvm/llvm-project/pull/79084


More information about the cfe-commits mailing list