[clang-tools-extra] [clang-tidy] Removed redundant-inline-specifier warning on static data members (PR #81423)
Piotr Zegar via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 11 12:47:46 PST 2024
================
@@ -88,12 +91,14 @@ void RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
this);
if (getLangOpts().CPlusPlus17) {
- Finder->addMatcher(
- varDecl(isInlineSpecified(),
- anyOf(isInternalLinkage(StrictMode),
- allOf(isConstexpr(), hasAncestor(recordDecl()))))
- .bind("var_decl"),
- this);
+ const auto IsPartOfRecordDecl = hasAncestor(recordDecl());
+ Finder->addMatcher(varDecl(isInlineSpecified(),
+ anyOf(allOf(isInternalLinkage(StrictMode),
+ unless(allOf(hasInitialization(),
----------------
PiotrZSL wrote:
Would be nice to verify that those variables are actually static with for example: isStaticStorageClass
https://github.com/llvm/llvm-project/pull/81423
More information about the cfe-commits
mailing list