[clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Feb 10 09:37:42 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: AtariDreams (AtariDreams)
<details>
<summary>Changes</summary>
Shorts are half an int, so HalfWidth and HalfAlign apply here.
---
Full diff: https://github.com/llvm/llvm-project/pull/81367.diff
1 Files Affected:
- (modified) clang/include/clang/Basic/TargetInfo.h (+2-2)
``````````diff
diff --git a/clang/include/clang/Basic/TargetInfo.h b/clang/include/clang/Basic/TargetInfo.h
index 48e9cec482755c..00851dc2fb0d07 100644
--- a/clang/include/clang/Basic/TargetInfo.h
+++ b/clang/include/clang/Basic/TargetInfo.h
@@ -489,11 +489,11 @@ class TargetInfo : public TransferrableTargetInfo,
/// Return the size of 'signed short' and 'unsigned short' for this
/// target, in bits.
- unsigned getShortWidth() const { return 16; } // FIXME
+ unsigned getShortWidth() const { return HalfWidth; }
/// Return the alignment of 'signed short' and 'unsigned short' for
/// this target.
- unsigned getShortAlign() const { return 16; } // FIXME
+ unsigned getShortAlign() const { return HalfAlign; }
/// getIntWidth/Align - Return the size of 'signed int' and 'unsigned int' for
/// this target, in bits.
``````````
</details>
https://github.com/llvm/llvm-project/pull/81367
More information about the cfe-commits
mailing list