[clang-tools-extra] [clang-tidy] Fix failing test after #80864 (PR #81171)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 8 10:47:17 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-tools-extra
Author: Krystian Stasiowski (sdkrystian)
<details>
<summary>Changes</summary>
The following test case in `clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp` is failing:
```cpp
#ifdef PR64602 // Should not crash
template <class T = void>
struct S
{
auto foo(auto);
};
template <>
auto S<>::foo(auto)
{
return 1;
}
// CHECK8: error: template parameter list matching the non-templated nested type 'S<>' should be empty ('template<>') [clang-diagnostic-error]
#endif
```
#<!-- -->80864 fixes a bug where we would (incorrectly) append invented template parameters to empty template parameter lists, which causes this test to fail.
---
Full diff: https://github.com/llvm/llvm-project/pull/81171.diff
1 Files Affected:
- (modified) clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp (+2-1)
``````````diff
diff --git a/clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp b/clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp
index 547f634a101c58..d0efc5ca763753 100644
--- a/clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp
+++ b/clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp
@@ -68,5 +68,6 @@ auto S<>::foo(auto)
{
return 1;
}
-// CHECK8: error: template parameter list matching the non-templated nested type 'S<>' should be empty ('template<>') [clang-diagnostic-error]
+// CHECK8: error: conflicting types for 'foo' [clang-diagnostic-error]
+// CHECK8: note: previous declaration is here
#endif
``````````
</details>
https://github.com/llvm/llvm-project/pull/81171
More information about the cfe-commits
mailing list