[clang] [NFC][clang][Driver] Specify options for <arg> with -save-temps=<arg> (PR #80921)

Jacob Lambert via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 7 12:48:11 PST 2024


https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/80921

>From 9f021f6d2b99ae73c47313ddc6043ab2af926f23 Mon Sep 17 00:00:00 2001
From: Jacob Lambert <jacob.lambert at amd.com>
Date: Tue, 6 Feb 2024 17:57:12 -0800
Subject: [PATCH 1/2] [NFC][clang][Driver] Specify options for <arg> with
 -save-temps=<arg>

---
 clang/include/clang/Driver/Options.td | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index 4b232b8aab722..6b13530799e10 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -5392,7 +5392,9 @@ def regcall4 : Flag<["-"], "regcall4">, Group<m_Group>,
   MarshallingInfoFlag<LangOpts<"RegCall4">>;
 def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[NoXarchOption]>,
   Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>,
-  HelpText<"Save intermediate compilation results.">;
+  HelpText<"Save intermediate compilation results. The <arg> option can be set "
+  "to cwd for current working directory, or obj which will save temporary "
+  "files in the same directory as the final output file">;
 def save_temps : Flag<["-", "--"], "save-temps">, Flags<[NoXarchOption]>,
   Visibility<[ClangOption, FlangOption, FC1Option]>,
   Alias<save_temps_EQ>, AliasArgs<["cwd"]>,

>From 52981d2f4131720d9e446b96c75db0769eef5c28 Mon Sep 17 00:00:00 2001
From: Jacob Lambert <jacob.lambert at amd.com>
Date: Wed, 7 Feb 2024 12:47:57 -0800
Subject: [PATCH 2/2] Don't describe option as arg, and fix white space

---
 clang/include/clang/Driver/Options.td | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index 6b13530799e10..4f498db2d43e6 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -5392,9 +5392,9 @@ def regcall4 : Flag<["-"], "regcall4">, Group<m_Group>,
   MarshallingInfoFlag<LangOpts<"RegCall4">>;
 def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[NoXarchOption]>,
   Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>,
-  HelpText<"Save intermediate compilation results. The <arg> option can be set "
-  "to cwd for current working directory, or obj which will save temporary "
-  "files in the same directory as the final output file">;
+  HelpText<"Save intermediate compilation results. <arg> can be set to cwd for "
+  "current working directory, or obj which will save temporary files in the "
+  "same directory as the final output file">;
 def save_temps : Flag<["-", "--"], "save-temps">, Flags<[NoXarchOption]>,
   Visibility<[ClangOption, FlangOption, FC1Option]>,
   Alias<save_temps_EQ>, AliasArgs<["cwd"]>,



More information about the cfe-commits mailing list