[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 6 08:52:34 PST 2024


================
@@ -2552,10 +2552,10 @@ class Parser : public CodeCompletionHandler {
   /// Starting with a scope specifier, identifier, or
   /// template-id that refers to the current class, determine whether
   /// this is a constructor declarator.
-  bool isConstructorDeclarator(
-      bool Unqualified, bool DeductionGuide = false,
-      DeclSpec::FriendSpecified IsFriend = DeclSpec::FriendSpecified::No,
-      const ParsedTemplateInfo *TemplateInfo = nullptr);
+  bool
+  isConstructorDeclarator(bool Unqualified, bool DeductionGuide = false,
+                          bool IsFriend = false,
----------------
erichkeane wrote:

I'm not a fan of 'bool' parames in general, so I'd prefer that the `FriendSpecified` stay in place.

https://github.com/llvm/llvm-project/pull/80171


More information about the cfe-commits mailing list