[llvm] [clang] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)
Aaron Ballman via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 6 06:04:17 PST 2024
================
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
----------------
AaronBallman wrote:
No worries about the extra pings (we'd rather see people "too" enthusiastic than disengaged!), just something to keep in mind for the future. :-)
The reason I think this diagnostic also needs to be updated is because of: https://godbolt.org/z/sEf4o8YY9 and https://godbolt.org/z/8oMWffoxY where it says `'expected-no-diagnostics'` in the diagnostic message. I think those should also say `'foo-no-diagnostics'` similar to how you've fixed it for the `no expected directives found` warning.
https://github.com/llvm/llvm-project/pull/78338
More information about the cfe-commits
mailing list