[clang] [CLANG] Fix INF/NAN warning. (PR #80290)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 5 07:33:46 PST 2024


================
@@ -73,7 +73,7 @@ def warn_pragma_debug_unexpected_argument : Warning<
 def warn_fp_nan_inf_when_disabled : Warning<
   "use of %select{infinity|NaN}0%select{| via a macro}1 is undefined behavior "
   "due to the currently enabled floating-point options">,
-  InGroup<DiagGroup<"nan-infinity-disabled">>;
+  InGroup<DiagGroup<"NanInfDisabledDocs">>;
----------------
AaronBallman wrote:

```suggestion
  InGroup<DiagGroup<"nan-infinity-disabled", NanInfDisabledDocs>>;
```
You were naming the warning group `NanInfDisabledDocs`, you still need the group name. This suggests we're missing test coverage because no tests broke despite the warning group name changing.

https://github.com/llvm/llvm-project/pull/80290


More information about the cfe-commits mailing list