[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

Alex Hoppen via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 2 09:57:14 PST 2024


================
@@ -508,24 +513,46 @@ static bool mayBeValidIdentifier(llvm::StringRef Ident) {
       !isAsciiIdentifierStart(Ident.front(), AllowDollar))
     return false;
   for (char C : Ident) {
+    if (AllowColon && C == ':')
----------------
ahoppen wrote:

Should we also allow spaces here if you spell the new method name as `doSomething: with:`?

--- 

Should we also check that the first selector piece is not empty? Ie. that `: with:` is not a valid selector.

https://github.com/llvm/llvm-project/pull/76466


More information about the cfe-commits mailing list