[clang] [llvm] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

[Lei Huang via cfe-commits]

lei137 wrote:

Hi Aokamal,

This maco was not taken into account in the implementation. Can you please open a bug and assign the issue to nemanjai?

Thank-you for reporting this.

Regards,
Lei

From: Aokamal ***@***.***>
Date: Tuesday, January 30, 2024 at 10:30 AM
To: llvm/llvm-project ***@***.***>
Cc: Lei Huang ***@***.***>, State change ***@***.***>
Subject: [EXTERNAL] Re: [llvm/llvm-project] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)
Hi, Sorry I kind of don't know much about the change. We have the following code snippet #if ABSL_HAVE_BUILTIN(__builtin_cpu_supports) if (__builtin_cpu_supports("avx2")) { .. . } #endif when run with arm cpu, it fails with error: builtin is
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
<https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!2U-qSTa06VIRMu4YcIkOZYJv87-YdAlWKJZhcdfdL-hOL9LK6PP42RfIRBxJiqbiimkckMLPKtrGCex3SbDVRbwy2koA67SnPo8$>
Report Suspicious <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!2U-qSTa06VIRMu4YcIkOZYJv87-YdAlWKJZhcdfdL-hOL9LK6PP42RfIRBxJiqbiimkckMLPKtrGCex3SbDVRbwy2koA67SnPo8$>


ZjQcmQRYFpfptBannerEnd

Hi,

Sorry I kind of don't know much about the change. We have the following code snippet

#if ABSL_HAVE_BUILTIN(__builtin_cpu_supports)

  if (__builtin_cpu_supports("avx2")) {

    ...

  }

#endif

when run with arm cpu, it fails with error: builtin is not supported on this target on the second if. Does it mean ABSL_HAVE_BUILTIN is not accurate here ?

—
Reply to this email directly, view it on GitHub<https://github.com/llvm/llvm-project/pull/68919#issuecomment-1917219523>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTLOI65B4HXCU6BOZW3G73YREGYJAVCNFSM6AAAAAA56ALXCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXGIYTSNJSGM>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>


https://github.com/llvm/llvm-project/pull/68919