[clang] [llvm] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 30 05:53:24 PST 2024


================
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
     "%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
     "%select{'expected-no-diagnostics' directive|other expected directives}0">;
 def err_verify_no_directives : Error<
-    "no expected directives found: consider use of 'expected-no-diagnostics'">;
+    "no expected directives found: consider use of '%0-no-diagnostics'">;
----------------
AaronBallman wrote:

> I guess elsewhere we refer to them as expected diagnostics, it's only in single quotes that we intend it to match the source?

Correct, there are expected (English sense of the word) directives, and there are 'expected' (syntax sense of the word) directives. We want single quotes around the syntax part.

https://github.com/llvm/llvm-project/pull/78338


More information about the cfe-commits mailing list