[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)
Chuanqi Xu via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 29 18:00:00 PST 2024
================
@@ -4099,7 +4099,9 @@ Decl *ASTReader::ReadDeclRecord(DeclID ID) {
// calls to Decl::getASTContext() by Decl's methods will find the
// TranslationUnitDecl without crashing.
D->setDeclContext(Context.getTranslationUnitDecl());
- Reader.Visit(D);
+
+ // Reading some declarations can result in deep recursion.
+ SemaObj->runWithSufficientStackSpace(DeclLoc, [&] { Reader.Visit(D); });
----------------
ChuanqiXu9 wrote:
Sema may not meaningful in ASTReader (e.g., we're compiling a pcm file).
```suggestion
clang::runWithSufficientStackSpace(...)
```
Also in this way, we can get better diagnotsics.
https://github.com/llvm/llvm-project/pull/79875
More information about the cfe-commits
mailing list