[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 28 00:17:25 PST 2024


yronglin wrote:

For this case, should

> > Should we also dump the sub-expr which in `CXXDefaultArgExpr`: for example: Consider:
> 
> I think this makes sense, but it can be a separate patch, unless it helps for testing.

Cool! Let's do it in a separate patch.

> FYI, we prefer merge commits instead of rebase + force push because Github reviews tend to loose context when doing force pushes / rebases in PRs

Thanks for the reminder, I may not have converted from the Phabricator habit yet. I tried to rebase to fix a libcxx ci issue(gdb_pretty_printer_test)



https://github.com/llvm/llvm-project/pull/76361


More information about the cfe-commits mailing list