[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)
Bhuminjay Soni via cfe-commits
cfe-commits at lists.llvm.org
Sat Jan 27 11:04:29 PST 2024
================
@@ -0,0 +1,189 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy -------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "UseStdMinMaxCheck.h"
+#include "../utils/ASTUtils.h"
+#include "clang/AST/ASTContext.h"
+#include "clang/AST/RecursiveASTVisitor.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/Lex/Preprocessor.h"
+#include <iostream>
+using namespace std;
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::readability {
+
+class ExprVisitor : public clang::RecursiveASTVisitor<ExprVisitor> {
+public:
+ explicit ExprVisitor(clang::ASTContext *Context) : Context(Context) {}
+ bool visitStmt(const clang::Stmt *S, bool &found,
+ clang::QualType &GlobalImplicitCastType) {
+
+ if (isa<clang::ImplicitCastExpr>(S) && !found) {
+ found = true;
+ const clang::ImplicitCastExpr *ImplicitCast =
+ cast<clang::ImplicitCastExpr>(S);
+ GlobalImplicitCastType = ImplicitCast->getType();
+ // Stop visiting children.
+ return false;
+ }
+ // Continue visiting children.
+ for (const clang::Stmt *Child : S->children()) {
+ if (Child) {
+ this->visitStmt(Child, found, GlobalImplicitCastType);
+ }
+ }
+
+ return true; // Continue visiting other nodes.
+ }
+
+private:
+ clang::ASTContext *Context;
----------------
11happy wrote:
yes yes , when I remove that private context its showing error, sorry if I am not able to get what you are trying to say , How can I ensure to not get error?
https://github.com/llvm/llvm-project/pull/77816
More information about the cfe-commits
mailing list