[clang] [libcxx] [SemaCXX] Implement CWG2137 (list-initialization from objects of the same type) (PR #77768)

via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 24 18:12:44 PST 2024


alexfh wrote:

> Doing a revert like this during our release process is actually quite a disturbance, 

My apologies, I didn't realize the additional complexities due to the release.

> particularly when the committer is actively working on the fix (and has identified it!). In the future please give them a chance to fix it before reverting on them.

As I understood the author, more time was needed to prepare the tests and the fix. I just tried to bring the tip of the tree to a good state soon (our internal release process was blocked on this) without putting any pressure on the author.

> ALSO, in the future, if you are going to do a revert while we are in a release process, you need to make sure to submit a request to revert it from the release branch at the same time, you cannot just revert in 'main'.

Should I send a PR to revert the commit in the release branch now?

https://github.com/llvm/llvm-project/pull/77768


More information about the cfe-commits mailing list