[clang] [llvm] [PseudoProbe] Mix and reorder block and call probe ID in lexical order (PR #75092)

via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 24 16:38:40 PST 2024


================
@@ -2112,6 +2112,14 @@ bool SampleProfileLoader::doInitialization(Module &M,
                                                DS_Warning));
       return false;
     }
+
+    if (!FunctionSamples::ProfileIsMixedProbeOrder) {
+      const char *Msg =
+          "Pseudo-probe-based profile is on an old version ID order which "
+          "could cause profile mismatch(performance regression)";
+      Ctx.diagnose(DiagnosticInfoSampleProfile(M.getModuleIdentifier(), Msg,
----------------
WenleiHe wrote:

Make this an error so issues like this won't go unnoticed? 

also:
`cause profile mismatch(performance regression`
->
`cause performance regression due to profile mismatch`

https://github.com/llvm/llvm-project/pull/75092


More information about the cfe-commits mailing list