[clang] [clang][dataflow] Eliminate two uses of `RecordValue::getLoc()`. (PR #79163)

[via cfe-commits]

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/79163

This is a small step towards eventually eliminating `RecordValue` entirely.


>From 8c56bce6b308f316ae8680bb3085e43e05e832a1 Mon Sep 17 00:00:00 2001
From: Martin Braenne <mboehme at google.com>
Date: Tue, 23 Jan 2024 16:20:44 +0000
Subject: [PATCH] [clang][dataflow] Eliminate two uses of
 `RecordValue::getLoc()`.

This is a small step towards eventually eliminating `RecordValue` entirely.
---
 clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
index 07dc3a9f76ac23b..3567ca41d07c77e 100644
--- a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
+++ b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
@@ -412,13 +412,13 @@ void Environment::initialize() {
           QualType ThisPointeeType =
               SurroundingMethodDecl->getFunctionObjectParameterType();
           setThisPointeeStorageLocation(
-              cast<RecordValue>(createValue(ThisPointeeType))->getLoc());
+              cast<RecordStorageLocation>(createObject(ThisPointeeType)));
         }
       }
     } else if (MethodDecl->isImplicitObjectMemberFunction()) {
       QualType ThisPointeeType = MethodDecl->getFunctionObjectParameterType();
       setThisPointeeStorageLocation(
-          cast<RecordValue>(createValue(ThisPointeeType))->getLoc());
+          cast<RecordStorageLocation>(createObject(ThisPointeeType)));
     }
   }
 }