[clang-tools-extra] [clang-tidy] Add support for lambdas in cppcoreguidelines-owning-memory (PR #77246)
Congcong Cai via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 22 23:28:37 PST 2024
================
@@ -147,10 +161,52 @@ void OwningMemoryCheck::registerMatchers(MatchFinder *Finder) {
// Matching on functions, that return an owner/resource, but don't declare
// their return type as owner.
Finder->addMatcher(
- functionDecl(hasDescendant(returnStmt(hasReturnValue(ConsideredOwner))
- .bind("bad_owner_return")),
- unless(returns(qualType(hasDeclaration(OwnerDecl)))))
- .bind("function_decl"),
+ functionDecl(
+ decl().bind("function_decl"),
+ hasBody(stmt(
+ stmt().bind("body"),
+ hasDescendant(
+ returnStmt(hasReturnValue(ConsideredOwner),
+ // Ignore sub-lambda expressions
+ hasAncestor(stmt(anyOf(equalsBoundNode("body"),
----------------
HerrCai0907 wrote:
Why here we need to check `hasAncestor(stmt(anyOf(equalsBoundNode("body")`, we get this `returnStmt` from `body hasDescendant`.
https://github.com/llvm/llvm-project/pull/77246
More information about the cfe-commits
mailing list