[clang] [clang-format] Limit how much work guessLanguage() can do (PR #78925)

via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 22 12:24:17 PST 2024


mydeveloperday wrote:

While I get this fixes the guessLanguage limitation, if its OOM the I guess isn't it going to be OOM for any format? (as you mention above), couldn't we just use the .clang-format-ignore file to say... hey don't bother with this file, we can't do it...

I feel like this will be a piece of code if we accept, might likely never go beyond the guess language usage. So it will just become more technical debt. Fixing the underlying problem isn't easy because it really amounts to changing the whole way clang-format deals with preprocessor paths.


https://github.com/llvm/llvm-project/pull/78925


More information about the cfe-commits mailing list