[clang] [compiler-rt] [clang-tools-extra] [PGO] Reland PGO's Counter Reset and File Dumping APIs #76471 (PR #78285)

Wael Yehia via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 22 09:54:11 PST 2024


w2yehia wrote:

@qiongsiwu explained to me offline that the issue on Windows is that calls __llvm_orderfile_dump fail so he's not able to execute the instrumented program if it calls that function.
Regarding the `compiler-rt/test/profile/instrprof-api.c` test. The disadvantage of having a profdata file is that it's hard to debug/reproduce; the Inputs directory currently has no profdata files, it's all source/text files. So, it's better to avoid storing the profdata.
We can disable the test on Windows.
Or keep the Windows coverage and `#ifdef` the `__llvm_orderfile_dump` API call on Windows (which will require versioning the expected output using LIT substitution magic).






https://github.com/llvm/llvm-project/pull/78285


More information about the cfe-commits mailing list