[llvm] [clang] [LinkerWrapper] Handle AMDGPU Target-IDs correctly when linking (PR #78359)

Joseph Huber via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 22 06:09:00 PST 2024


jhuber6 wrote:

> FYI. There is a failure in liner-wrapper.c in https://buildkite.com/llvm-project/github-pull-requests/builds/30337#018d1aaa-8225-4630-a5f0-527d1c7c129d
> 
> ```
> # note: command had no output on stdout or stderr
>   | # error: command failed with exit status: 1
>   | # executed command: 'c:\ws\src\build\bin\filecheck.exe' 'C:\ws\src\clang\test\Driver\linker-wrapper.c' --check-prefix=AMD-TARGET-ID
>   | # .---command stderr------------
>   | # \| C:\ws\src\clang\test\Driver\linker-wrapper.c:172:19: error: AMD-TARGET-ID: expected string not found in input
>   | # \| // AMD-TARGET-ID: clang{{.*}} -o {{.*}}.img --target=amdgcn-amd-amdhsa -mcpu=gfx90a:xnack+ -O2 -Wl,--no-undefined {{.*}}.o {{.*}}.o
>   | # \|                   ^
>   | # \| <stdin>:1:1: note: scanning from here
>   | # \| c:\ws\src\build\bin\clang-linker-wrapper.exe: error: invalid argument
>   | # \| ^
>   | # \|
>   | # \| Input file: <stdin>
>   | # \| Check file: C:\ws\src\clang\test\Driver\linker-wrapper.c
>   | # \|
>   | # \| -dump-input=help explains the following input dump.
>   | # \|
>   | # \| Input was:
>   | # \| <<<<<<
>   | # \|            1: c:\ws\src\build\bin\clang-linker-wrapper.exe: error: invalid argument
>   | # \| check:172     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
>   | # \|            2: invalid argument
>   | # \| check:172     ~~~~~~~~~~~~~~~~~
>   | # \| >>>>>>
>   | # `-----------------------------
>   | # error: command failed with exit status: 1
> ```

Is that not fixed? I pushed something to address that yesterday afternoon. 

https://github.com/llvm/llvm-project/pull/78359


More information about the cfe-commits mailing list