[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)
Jimmy Z via cfe-commits
cfe-commits at lists.llvm.org
Sat Jan 20 21:00:27 PST 2024
jimmy-zx wrote:
> Looks good overall. It's good that you wrote your own tests, but it would also be nice to mirror tests in `clang/unittests/libclang/LibclangTest.cpp` which test the same API. This way we can identify issues in binding layer itself (when C++ tests pass, but Python tests don't, or vise versa,)
I have reviewed the tests for libclang and it appears that there are already tests for the rewriter, which are more extensive than the ones I wrote. Therefore, I have decided to mirror the tests from libclang in the Python binding. Please let me know if this approach is appropriate.
https://github.com/llvm/llvm-project/pull/77269
More information about the cfe-commits
mailing list