[clang] fd49ef1 - Removed a late added test-case from the tests for #74629

Ben Dunbobbin via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 19 17:38:43 PST 2024


Author: Ben Dunbobbin
Date: 2024-01-20T01:35:06Z
New Revision: fd49ef1eb3de7eb2be5f7ddd469a005917cc1988

URL: https://github.com/llvm/llvm-project/commit/fd49ef1eb3de7eb2be5f7ddd469a005917cc1988
DIFF: https://github.com/llvm/llvm-project/commit/fd49ef1eb3de7eb2be5f7ddd469a005917cc1988.diff

LOG: Removed a late added test-case from the tests for #74629

This test-case was generating invalid IR and causing the test to fail.

Given that the reviewer initially accepted the change without this
test case I feel that it is appropriate to remove this test case,
to get the build to pass, and find a way to reimplement this test-case
in a later commit.

Added: 
    

Modified: 
    clang/test/CodeGenCXX/visibility-dllstorageclass.cpp

Removed: 
    


################################################################################
diff  --git a/clang/test/CodeGenCXX/visibility-dllstorageclass.cpp b/clang/test/CodeGenCXX/visibility-dllstorageclass.cpp
index a44ff1316d94c5..3ea00bd4889923 100644
--- a/clang/test/CodeGenCXX/visibility-dllstorageclass.cpp
+++ b/clang/test/CodeGenCXX/visibility-dllstorageclass.cpp
@@ -43,17 +43,6 @@
 // RUN:     -x c++  %s -S -emit-llvm -o - | \
 // RUN:   FileCheck %s --check-prefixes=ALL_KEEP
 
-//// Show that omitting -fvisibility-from-dllstorageclass causes the other options to be ignored.
-// RUN: %clang_cc1 -triple x86_64-unknown-windows-itanium -fdeclspec \
-// RUN:     -fvisibility=hidden \
-// RUN:     -fapply-global-visibility-to-externs \
-// RUN:     -fvisibility-dllexport=protected \
-// RUN:     -fvisibility-nodllstorageclass=protected \
-// RUN:     -fvisibility-externs-dllimport=protected \
-// RUN:     -fvisibility-externs-nodllstorageclass=protected \
-// RUN:     -x c++  %s -S -emit-llvm -o - | \
-// RUN:   FileCheck %s --check-prefixes=ALL_KEEP
-
 // Local
 static void l() {}
 void use_locals(){l();}


        


More information about the cfe-commits mailing list