[clang] [llvm] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

NAKAMURA Takumi via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 19 14:18:42 PST 2024


================
@@ -11,6 +11,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "SystemZ.h"
+#include "clang/AST/Decl.h"
----------------
chapuni wrote:

Thanks. Now you can remove this. This is the only point from my side.

> (note that clang itself builds fine)
You were introducing layering violation. "Clang could be built apparently."

> Why did you remove clangAST from the cmake file to begin with - was there some discussion preceding this?
In principle, we can prune redundant deps. In contrast, the discussion would be required for introducing new deps.

https://github.com/llvm/llvm-project/pull/73511


More information about the cfe-commits mailing list