[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

Sander de Smalen via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 19 07:01:21 PST 2024


================
@@ -3005,6 +3005,15 @@ enum ArmStreamingType {
   ArmStreamingOrSVE2p1
 };
 
+enum ArmSMEState : unsigned {
+  ArmNoState = 0,
+
+  ArmInZA = 0b01,
+  ArmOutZA = 0b10,
+  ArmInOutZA = 0b11,
+  ArmZAMask = 0b11,
----------------
sdesmalen-arm wrote:

I'm not really convinced that's better because they're two different things. One is an enum value for the state of ZA, and the other is a bitmask. If we'd want to change the encoding of the ZA attributes, we don't necessarily have to update the mask.

https://github.com/llvm/llvm-project/pull/78258


More information about the cfe-commits mailing list