[clang] [clang-format] Support of TableGen identifiers beginning with a number. (PR #78571)

Björn Schäpers via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 18 12:26:28 PST 2024


================
@@ -804,6 +806,46 @@ void FormatTokenLexer::handleTableGenMultilineString() {
       FirstLineText, MultiLineString->OriginalColumn, Style.TabWidth, Encoding);
 }
 
+void FormatTokenLexer::handleTableGenNumericLikeIdentifier() {
+  FormatToken *Tok = Tokens.back();
+  // TableGen identifiers can begin with digits. Such tokens are lexed as
+  // numeric_constant now.
+  if (Tok->isNot(tok::numeric_constant))
+    return;
+  StringRef Text = Tok->TokenText;
+  // Identifiers cannot begin with + or -.
+  if (Text.size() < 1 || Text[0] == '+' || Text[0] == '-')
+    return;
+  // The following check is based on llvm::TGLexer::LexToken.
+  if (isdigit(Text[0])) {
+    size_t I = 0;
+    char NextChar = (char)0;
+    // Identifiers in TalbleGen may begin with digits. Skip to first non-digit.
+    do {
+      NextChar = Text[I++];
+    } while (I < Text.size() && isdigit(NextChar));
+    // All the characters are digits.
+    if (I >= Text.size())
+      return;
----------------
HazardyKnusperkeks wrote:

```suggestion
    // Identifiers in TalbleGen may begin with digits. Skip to first non-digit.
    const auto NonDigitPos = Text.find_if([](char C) { return !isdigit(C); }, I);
    // All the characters are digits.
    if (NonDigitPos == StringRef::npos)
      return;
    char NextChar = Text[NonDigitPos];
```
Express your intent.

https://github.com/llvm/llvm-project/pull/78571


More information about the cfe-commits mailing list