[clang] 2b804f8 - [LinkerWrapper][Obvious] Fix move on temporary object

Joseph Huber via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 18 08:42:22 PST 2024


Author: Joseph Huber
Date: 2024-01-18T10:42:13-06:00
New Revision: 2b804f875579995b1588f1a079e265929163d0e4

URL: https://github.com/llvm/llvm-project/commit/2b804f875579995b1588f1a079e265929163d0e4
DIFF: https://github.com/llvm/llvm-project/commit/2b804f875579995b1588f1a079e265929163d0e4.diff

LOG: [LinkerWrapper][Obvious] Fix move on temporary object

Summary:
This causes warnings because it is already a temporary and does not need
to be moved.

Added: 
    

Modified: 
    clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

Removed: 
    


################################################################################
diff  --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
index 03c83e2f92b3220..bfb54f58330bdad 100644
--- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
+++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
@@ -1439,7 +1439,7 @@ getDeviceInput(const ArgList &Args) {
           if (Index == CompatibleTargets.size() - 1)
             InputFiles[ID].emplace_back(std::move(Binary));
           else
-            InputFiles[ID].emplace_back(std::move(Binary.copy()));
+            InputFiles[ID].emplace_back(Binary.copy());
         }
 
         // If we extracted any files we need to check all the symbols again.


        


More information about the cfe-commits mailing list