[clang] d5000e9 - rename to 'try' isntead of 'Try'x

[David Blaikie via cfe-commits]

Be good to have more description of "why" in commit messages in general
(the "what" is provided by the patch itself, especially when it's a small
one like this) - I guess this was to match naming conventions, that this
file generally already follows lower-first, etc.

On Tue, Jan 16, 2024 at 7:04 AM via cfe-commits <cfe-commits at lists.llvm.org>
wrote:

>
> Author: erichkeane
> Date: 2024-01-16T07:04:28-08:00
> New Revision: d5000e9cd95b720fc9082da6cdcdb2c865303dcf
>
> URL:
> https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf
> DIFF:
> https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf.diff
>
> LOG: rename to 'try' isntead of 'Try'x
>
> Added:
>
>
> Modified:
>     clang/lib/Parse/ParseOpenACC.cpp
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/clang/lib/Parse/ParseOpenACC.cpp
> b/clang/lib/Parse/ParseOpenACC.cpp
> index 018c61de4be369..a5a028e1c6a799 100644
> --- a/clang/lib/Parse/ParseOpenACC.cpp
> +++ b/clang/lib/Parse/ParseOpenACC.cpp
> @@ -183,7 +183,7 @@ bool isTokenIdentifierOrKeyword(Parser &P, Token Tok) {
>  /// Return 'true' if the special token was matched, false if no special
> token,
>  /// or an invalid special token was found.
>  template <typename DirOrClauseTy>
> -bool TryParseAndConsumeSpecialTokenKind(Parser &P,
> OpenACCSpecialTokenKind Kind,
> +bool tryParseAndConsumeSpecialTokenKind(Parser &P,
> OpenACCSpecialTokenKind Kind,
>                                          DirOrClauseTy DirOrClause) {
>    Token IdentTok = P.getCurToken();
>    // If this is an identifier-like thing followed by ':', it is one of the
> @@ -713,7 +713,7 @@ void Parser::ParseOpenACCCacheVarList() {
>    // The VarList is an optional `readonly:` followed by a list of a
> variable
>    // specifications. Consume something that looks like a 'tag', and
> diagnose if
>    // it isn't 'readonly'.
> -  if (TryParseAndConsumeSpecialTokenKind(*this,
> +  if (tryParseAndConsumeSpecialTokenKind(*this,
>
> OpenACCSpecialTokenKind::ReadOnly,
>                                           OpenACCDirectiveKind::Cache)) {
>      // FIXME: Record that this is a 'readonly' so that we can use that
> during
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20240117/3c0a068c/attachment.html>