https://github.com/ilovepi commented: I think this is basically good IMO once we settle on the default values. You should still get approval from one of the RISCV code owners before landing though. https://github.com/llvm/llvm-project/pull/68075